require-dev compatibility for Doctrine ORM 3 #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
commented
Mar 17, 2024
| @@ -14,7 +14,7 @@ | |||
| </field> | |||
| <field name="width" column="width" type="integer" nullable="true"/> | |||
| <field name="height" column="height" type="integer" nullable="true"/> | |||
| <field name="length" column="length" type="decimal" nullable="true"/> | |||
| <field name="length" column="length" type="decimal" nullable="true" precision="10"/> | |||
There was a problem hiding this comment.
This is needed with ORM 3. Otherwise will lead to
Doctrine\DBAL\Exception\InvalidColumnType\ColumnPrecisionRequired: Column precision is not specified
says
Defaults to 10.
Still going to verify this
There was a problem hiding this comment.
Schema create SQL
ORM 2 without specified precision: length NUMERIC(10, 0) DEFAULT NULL
ORM 3 with specified precision = 10: length NUMERIC(10, 0) DEFAULT NULL
So this change should keep BC
VincentLanglet
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because its BC.
Part of sonata-project/dev-kit#2674
Changelog